Auto-attach recently viewed charms and add listRecent() tool
#1986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and introduce `listRecent` tool
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/patterns/chatbot.tsx">
<violation number="1" location="packages/patterns/chatbot.tsx:459">
Auto-attached charms rendered by the bar can no longer be removed: the bar now reads from attachmentsWithRecent, but removeAttachment still mutates only the base allAttachments cell, so deleting the auto entry is impossible and the chip reappears immediately.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| <ct-hstack align="center" gap="1"> | ||
| <ct-attachments-bar | ||
| attachments={allAttachments} | ||
| attachments={attachmentsWithRecent} |
There was a problem hiding this comment.
Auto-attached charms rendered by the bar can no longer be removed: the bar now reads from attachmentsWithRecent, but removeAttachment still mutates only the base allAttachments cell, so deleting the auto entry is impossible and the chip reappears immediately.
Prompt for AI agents
Address the following comment on packages/patterns/chatbot.tsx at line 459:
<comment>Auto-attached charms rendered by the bar can no longer be removed: the bar now reads from attachmentsWithRecent, but removeAttachment still mutates only the base allAttachments cell, so deleting the auto entry is impossible and the chip reappears immediately.</comment>
<file context>
@@ -389,7 +456,7 @@ export default recipe<ChatInput, ChatOutput>(
<ct-hstack align="center" gap="1">
<ct-attachments-bar
- attachments={allAttachments}
+ attachments={attachmentsWithRecent}
removable
onct-remove={removeAttachment({ allAttachments })}
</file context>
jkomoros
pushed a commit
that referenced
this pull request
Oct 30, 2025
* Auto-attach currently viewed charm and introduce `listRecent` tool * Make system prompt customizable for `chatbot.tsx`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chatbot.tsxSummary by cubic
Auto-attaches the most recently viewed charm to each chat and adds a listRecent tool so the assistant can pull in recent items without extra clicks, addressing Linear CT-1013. The chatbot system prompt is now configurable; Omnibox keeps the previous behavior by passing the existing prompt.